Re: Issue in GIN fast-insert: XLogBeginInsert + Read/LockBuffer ordering

[Zhang Mingli]

Hi,

On Sep 8, 2022, 19:08 +0800, Matthias van de Meent 
<boekewurm+postg...@gmail.com>, wrote:
>
> PFA a patch that rectifies this issue, by moving the XLogBeginInsert()
> down to where 1.) we have all relevant buffers pinned and locked, and
> 2.) we're in a critical section, making that part of the code
> consistent with the general scheme for XLog insertion.
>
In the same function, there is disorder of XLogBeginInsert and 
START_CRIT_SECTION.

```
collectordata = ptr = (char *) palloc(collector->sumsize);

 data.ntuples = collector->ntuples;

 if (needWal)
   XLogBeginInsert();

 START_CRIT_SECTION();
```

Shall we adjust that too?

Regards,
Zhang Mingli