I wrote:
> On Fri, 16 Sep 2022 at 20:13, Simon Riggs <simon.ri...@enterprisedb.com>
> wrote:
>> Patch 002 replaces this with a more meaningful error message, which
>> matches our fine manual.
>> https://www.postgresql.org/docs/current/sql-createtable.html
>>
>> ERROR: cannot specify storage options for a partitioned table
>> HINT: specify storage options on leaf partitions instead
>
> Looks good. Does this means we don't need the partitioned_table_reloptions()
> function and remove the reloptions validation in DefineRelation() for
> partitioned table. Or we can ereport() in partitioned_table_reloptions().
I want to know why we should do validation for partitioned tables even if it
doesn't support storage parameters?
/*
* There are no options for partitioned tables yet, but this is able to do
* some validation.
*/
return (bytea *) build_reloptions(reloptions, validate,
RELOPT_KIND_PARTITIONED,
0, NULL, 0);
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
