CK Tan <ck...@vitessedata.com> writes: > I see in the texteq() function calls to DatumGetTextPP() are followed > by conditional calls to PG_FREE_IF_COPY. e.g.
That's because texteq() is potentially usable as a btree index function, and btree isn't too forgiving about leaks. > However, in textlike(), PG_FREE_IF_COPY calls are missing. > https://github.com/postgres/postgres/blob/master/src/backend/utils/adt/like.c#L283 textlike() isn't a member of any btree opclass. > Is this a memory leak bug? Not unless you can demonstrate a case where it causes problems. For the most part, such functions run in short-lived contexts. regards, tom lane
