On Fri, Sep 2, 2022 at 8:45 AM Peter Smith <smithpb2...@gmail.com> wrote: > > On Thu, Sep 1, 2022 at 7:53 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Fri, Aug 26, 2022 at 7:33 AM Peter Smith <smithpb2...@gmail.com> wrote: > > > > > > > Few comments on both the patches: > > v4-0001* > > ========= > > 1. > > Furthermore, if the table uses > > + <literal>REPLICA IDENTITY FULL</literal>, specifying a column list is > > not > > + allowed (it will cause publication errors for <command>UPDATE</command> > > or > > + <command>DELETE</command> operations). > > > > This line sounds a bit unclear to me. From this like it appears that > > the following operation is not allowed: > > > > postgres=# create table t1(c1 int, c2 int, c3 int); > > CREATE TABLE > > postgres=# Alter Table t1 replica identity full; > > ALTER TABLE > > postgres=# create publication pub1 for table t1(c1); > > CREATE PUBLICATION > > > > However, what is not allowed is the following: > > postgres=# delete from t1; > > ERROR: cannot delete from table "t1" > > DETAIL: Column list used by the publication does not cover the > > replica identity. > > > > I am not sure if we really need this line but if so then please try to > > make it more clear. I think the similar text is present in 0002 patch > > which should be modified accordingly. > > > > The "Furthermore…" sentence came from the commit message [1]. But I > agree it seems redundant/ambiguous, so I have removed it (and removed > the same in patch 0002). >
Thanks, pushed your first patch. -- With Regards, Amit Kapila.
