got it, thanks. Tom Lane <t...@sss.pgh.pa.us>于2022年9月2日 周五01:13写道：
> Junwang Zhao <zhjw...@gmail.com> writes: > > I'm a little confused when we should call *pfree* and when we should not. > > A few lines before there is a call *text_to_cstring* in which it invokes > > *pfree* to free the unpacked text [0]. I'm just thinking that since *s* > has > > been duplicated, we should free it, that's where the patch comes from. > > By and large, the server is designed so that small memory leaks don't > matter: the space will be reclaimed when the current memory context > is deleted, and most code runs in reasonably short-lived contexts. > Individually pfree'ing such allocations is actually a net negative, > because it costs cycles and code space. > > There are places where a leak *does* matter, but unless you can > demonstrate that this is one, it's not worth changing. > > regards, tom lane > -- Regards Junwang Zhao
