On Fri, Aug 19, 2022 at 4:36 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Hi Wang-san, > > Here is some more information about my v21-0001 review [2] posted yesterday. > > ~~ > > If the streaming=parallel will be disallowed for publishers not using > protocol 4 (see Amit's post [1]), then please ignore all my previous > review comments about the protocol descriptions (see [2] comments #4b, > #7b, #47a, #47b). > > ~~ > > Also, I was having second thoughts about the name replacement for the > 'main_worker_pid' member (see [2] comments #1b, #49). Previously I > suggested 'apply_leader_pid', but now I think something like > 'apply_bgworker_leader_pid' would be better. (It's a bit verbose, but > now it gives the proper understanding that only an apply bgworker can > have a valid value for this member). >
I find your previous suggestion to name it 'apply_leader_pid' better. According to me, it conveys the meaning. -- With Regards, Amit Kapila.
