On Wed, Aug 17, 2022 at 8:52 PM Robert Haas <robertmh...@gmail.com> wrote: > > On Wed, Aug 17, 2022 at 12:41 AM Bharath Rupireddy > <bharath.rupireddyforpostg...@gmail.com> wrote: > > Agreed. > > > > Here's a patch (for V15 as well) fixing this bug, please review. > > Couldn't you simplify this further by removing the lsn argument from > GetWALRecordInfo and using record->ReadRecPtr instead? Then > InitXLogReaderState's second argument could be XLogRecPtr instead of > XLogRecPtr *.
Done. XLogFindNextRecord() stores the first valid record in EndRecPtr and the ReadRecPtr is set to InvalidXLogRecPtr by calling XLogBeginRead(). And XLogNextRecord() sets ReadRecPtr which we can use. PSA v2 patches. -- Bharath Rupireddy RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/
v2-master-Use-correct-LSN-for-error-reporting-in-pg_walinsp.patch
Description: Binary data
v2-PG15-Use-correct-LSN-for-error-reporting-in-pg_walinsp.patch
Description: Binary data
