Hi,
On 8/10/22 11:25 PM, Greg Stark wrote:
On Wed, 10 Aug 2022 at 04:05, Drouvot, Bertrand <bdrou...@amazon.com> wrote:
Hi,
On 8/9/22 6:00 PM, Greg Stark wrote:
On Tue, 9 Aug 2022 at 06:19, Drouvot, Bertrand <bdrou...@amazon.com> wrote:
What do you think about adding a function in core PG to provide such
functionality? (means being able to retrieve all the stats (+ eventually
add some filtering) without the need to connect to each database).
I'm working on it myself too. I'll post a patch for discussion in a bit.
Great! Thank you!
So I was adding the code to pgstat.c because I had thought there were
some data types I needed and/or static functions I needed. However you
and Andres encouraged me to check again now. And indeed I was able,
after fixing a couple things, to make the code work entirely
externally.
Nice!
Though I still think to have an SQL API in core could be useful to.
As Andres was not -1 about that idea (as it should be low cost to add
and maintain) as long as somebody cares enough to write something: then
I'll give it a try and submit a patch for it.
This is definitely not polished and there's a couple obvious things
missing. But at the risk of embarrassment I've attached my WIP. Please
be gentle :) I'll post the github link in a bit when I've fixed up
some meta info.
Thanks! I will have a look at it on github (once you share the link).
Regards,
--
Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com
