On Sun, Aug 7, 2022 at 1:29 PM Andres Freund <and...@anarazel.de> wrote: > 0001: __func__ is C99, so we don't need to support fallbacks
+1, and my scraped data agrees. I believe our minimum MSVC is current 2015, and this says it has it (it doesn't let you select older versions in the version drop-down, but we don't care about older versions): https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-140 > 0002: windows: We've unconditionally defined HAVE_MINIDUMP_TYPE for msvc > forever, we > can rely on it for mingw too * If supported on the current platform, set up a handler to be called if * the backend/postmaster crashes with a fatal signal or exception. */ -#if defined(WIN32) && defined(HAVE_MINIDUMP_TYPE) +#if defined(WIN32) Personally I'd remove "If supported on the current platform, " and shove the rest of the comment inside the #if defined(WIN32), but that's just me... > 0003: aix: aix3.2.5, aix4.1 are not even of historical interest at this point > - 4.1 was released before the first commit in our commit history Wow. > 0004: solaris: these gcc & gnu ld vs sun stuff differences seem unnecessary or > outdated LGTM from a look at the current man page. > I checked and the relevant options (-shared, -Wl,-Bsymbolic, -Wl,-soname) > work even on solaris 10 with developerstudio12.5 (not the latest) FWIW I'd call Solaris 10 EOL'd (it's in some sure-pay-us-but-we-aren't-really-going-to-fix-it phase with a lifetime similar to the actual sun). > 0005: those broken system headers look to have been repaired a good while ago, > or, in the case of irix, we don't support the platform anymore Nice archeology.
