On 6/30/22 16:16, Jacob Champion wrote: > [CFM hat] Since you feel strongly about the patch, and we're short on > time before the commitfest starts, I have re-registered this. That way > there can be an explicit decision as opposed to a pocket veto by me.
[CFM hat] Okay, with another CF come and gone without review I feel much more confident about closing this as Returned with Feedback. [dev hat] Specifically I don't think this patch is reviewable alone; it needs to be grouped with the functionality change that needed the additional coverage. That way it'll be much easier for a reviewer to decide whether 1) it's covering the right spots and 2) it's an overall useful addition. That doesn't mean you have to smash it into another commit; it can be a separate test commit as part of a bigger patchset, and the commit message can include the motivation for why you wrote the new test. Thanks, --Jacob
