On 2022-07-27 We 10:58, Tom Lane wrote: > Andrew Dunstan <and...@dunslane.net> writes: >> The alternative I thought of would be to switch msys to using our >> dirent.c. Probably not too hard, but certainly more work than reverting. > If you ask me, the shortest-path general-purpose fix is to insert > > #if MSYS > if (pgwin32_is_junction(path)) > return PGFILETYPE_DIR; > #endif > > at the start of get_dirent_type. (I'm not sure how to spell the > #if test.) We could look at using dirent.c later, but I think > right now it's important to un-break the buildfarm ASAP. > >
+1. I think you spell it: #if defined(WIN32) && !defined(_MSC_VER) (c.f. libpq-be.h) cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
