Is it correct to say, "invalid data in file \"%s\"", BACKUP_LABEL_FILE in do_pg_backup_stop?

[Bharath Rupireddy]

Hi,

After the commit [1], is it correct to say errmsg("invalid data in file
\"%s\"", BACKUP_LABEL_FILE))); in do_pg_backup_stop() when we hold the
contents in backend global memory, not actually reading from backup_label
file? However, it is correct to say that in read_backup_label.

IMO, we can either say "invalid backup_label contents found" or we can be
more descriptive and say "invalid "START WAL LOCATION" line found in
backup_label content" and "invalid "BACKUP FROM" line found in
backup_label content" and so on.

Thoughts?

[1]
commit 39969e2a1e4d7f5a37f3ef37d53bbfe171e7d77a
Author: Stephen Frost <sfr...@snowman.net>
Date:   Wed Apr 6 14:41:03 2022 -0400

    Remove exclusive backup mode

errmsg("invalid data in file \"%s\"", BACKUP_LABEL_FILE)));

Regards,
Bharath Rupireddy.