On Mon, Jul 18, 2022 at 8:55 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > Um ... you seem to have removed some useful comments?
I don't think that the stuff about making them into a GUC is useful myself. > Personally I wouldn't do this, as I don't think the renaming > brings much benefit, and it will create a hazard for back-patching > any fixes that might be needed in that code. I'm not hugely upset > about it, but that's the way I'd vote if asked. In that case I withdraw the patch. FWIW I wrote the patch during the course of work on new feature development. A patch that added a couple of similar constants a bit further down. Seemed neater this way, but it's certainly not worth arguing over. -- Peter Geoghegan
