On Tue, Jun 21, 2022 at 09:07:42AM -0700, David G. Johnston wrote:
> On Tue, Jun 21, 2022 at 6:49 AM Aleksander Alekseev <aleksan...@timescale.com>
> wrote:
>
> Hi David,
>
> > It's basically a glorified cross-reference. I didn't dislike directing
> the reader to the internals section enough to try and establish a better
> location for the main content.
>
> One problem I see is that:
>
> + [..], but as there is no pre-existing data, visibility checks are
> unnecessary.
>
> ... allows a wide variety of interpretations, most of which will be
> wrong. And all in all I find an added paragraph somewhat cryptic.
>
> Yeah, I'd probably have to say "but since no existing record is being
> modified,
> visibility checks are unnecessary".
>
> Is there a specific mis-interpretation that first came to mind for you that I
> can consider specifically?
>
>
> If the goal is to add a cross-reference I suggest keeping it short,
> something like "For additional details on various corner cases please
> see ...".
>
> That does work, and I may end up there, but it feels unsatisfying to be so
> vague/general.
I was not happy with putting this in the Transaction Isolation section.
I rewrote it and put it in the INSERT secion, right before ON CONFLICT;
patch attached.
--
Bruce Momjian <br...@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Indecision is a decision. Inaction is an action. Mark Batterson
diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml
index a9af9959c0..29e92546ef 100644
--- a/doc/src/sgml/ref/insert.sgml
+++ b/doc/src/sgml/ref/insert.sgml
@@ -75,6 +75,11 @@ INSERT INTO <replaceable class="parameter">table_name</replaceable> [ AS <replac
</para>
<para>
+ <command>INSERT</command> into tables that lack unique indexes will
+ not be blocked by concurrent activity. Tables with unique indexes
+ might block if concurrent sessions perform actions that lock or modify
+ rows matching the unique index values being inserted; the details
+ are covered in <xref linkend="index-unique-checks"/>.
<literal>ON CONFLICT</literal> can be used to specify an alternative
action to raising a unique constraint or exclusion constraint
violation error. (See <xref linkend="sql-on-conflict"/> below.)
