On Thu, Jul 07, 2022 at 02:07:26PM -0400, David Steele wrote: > On 7/7/22 12:18, Nathan Bossart wrote: >> On Thu, Jul 07, 2022 at 10:46:23AM -0400, David Steele wrote: >> >> > There are plenty of ways that already-archived WAL might get archived again >> > and this is just one of them. >> >> What are some of the others? I was aware of the case that was fixed in >> ff9f111, where we might try to re-archive a file with different contents, >> but I'm curious what other ways you've seen this happen. > > On the PG side, crashes and (IIRC) immediate shutdown. > > In general, any failure in the archiver itself. Storage, memory, network, > etc. There are plenty of ways that the file might make it to storage but > postgres never gets notified, so it will retry. > > Any archiver that is not tolerant of this fact is not going to be very > useful and this patch only makes it slightly more true.
Ah, got it, makes sense. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
