On Thu, Jul 7, 2022 at 12:53 AM Andres Freund <and...@anarazel.de> wrote: > > Hi, > > On 2022-07-06 11:41:46 +0900, Masahiko Sawada wrote: > > diff --git a/src/test/regress/sql/subscription.sql > > b/src/test/regress/sql/subscription.sql > > index 74c38ead5d..6a46956f6e 100644 > > --- a/src/test/regress/sql/subscription.sql > > +++ b/src/test/regress/sql/subscription.sql > > @@ -30,6 +30,12 @@ CREATE SUBSCRIPTION regress_testsub CONNECTION > > 'dbname=regress_doesnotexist' PUB > > COMMENT ON SUBSCRIPTION regress_testsub IS 'test subscription'; > > SELECT obj_description(s.oid, 'pg_subscription') FROM pg_subscription s; > > > > +-- Check if the subscription stats are created and stats_reset is updated > > +-- by pg_stat_reset_subscription_stats(). > > +SELECT subname, stats_reset IS NULL stats_reset_is_null FROM > > pg_stat_subscription_stats ORDER BY 1; > > Why use ORDER BY 1 instead of just getting the stats for the subscription we > want to test? Seems a bit more robust to show only that one, so we don't get > unnecessary changes if the test needs to create another subscription or such.
Right, it's more robust. I've updated the patch accordingly. > > > > +SELECT pg_stat_reset_subscription_stats(oid) FROM pg_subscription; > > +SELECT subname, stats_reset IS NULL stats_reset_is_null FROM > > pg_stat_subscription_stats ORDER BY 1; > > + > > Perhaps worth resetting again and checking that the timestamp is bigger than > the previous timestamp? You can do that with \gset etc. Agreed. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
v3-0001-Create-subscription-stats-entry-at-CREATE-SUBSCRI.patch
Description: Binary data
