On Wed, Jul 6, 2022 at 7:55 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > Okay, changed that and changed a few more occurrences in 0001 which > were on similar lines. I also tested the performance of pg_bench > where concurrently I am running the script which creates/drops > relation but I do not see any regression with fairly small values of > VAR_RELNUMBER_PREFETCH, the smallest value I tried was 8. That > doesn't mean I am suggesting this small value but I think we can keep > the value something like 512 or 1024 without worrying much about the > performance, so changed to 512 in the latest patch.
OK, I have committed 0001 now with a few changes. pgindent did not agree with some of your whitespace changes, and I also cleaned up a few long lines. I replaced one instance of InvalidOid with InvalidRelFileNumber also, and changed a word in a comment. I think 0002 and 0003 need more work yet; I'll try to write a review of those soon. -- Robert Haas EDB: http://www.enterprisedb.com
