On Mon, Jun 27, 2022 at 07:32:08PM +0900, Michael Paquier wrote:
> On Mon, Jun 27, 2022 at 12:04:57AM -0700, Noah Misch wrote:
> > One can adapt the test to the server behavior by having the test wait for
> > the
> > archiver to start, as attached. This is sufficient to make check-world pass
> > with the above sleep in place. I think we should also modify the
> > PostgresNode
> > archive_command to log a message. That lack of logging was a obstacle
> > upthread (as seen in commit 3279cef) and again here.
>
> ? qq{copy "%p" "$path\\\\%f"}
> - : qq{cp "%p" "$path/%f"};
> + : qq{echo >&2 "ARCHIVE_COMMAND %p"; cp "%p" "$path/%f"};
>
> This is a bit inelegant. Perhaps it would be better through a perl
> wrapper like cp_history_files?
I see it the other way. Replacing a 49-character compound command with a
wrapper script would gain no particular advantage, and it would give readers
of the test code one more file to open and understand.
