On Tue, Jun 28, 2022 at 10:12:18AM +0100, Dagfinn Ilmari Mannsåker wrote: > That makes sense, but I still think the query_log() function definition > should go at the end (after done_testing()), so the machinery doesn't > distract from what's actually being tested.
The majority of TAP scripts have their subroutines at the beginning of the script, and there are few having that at the end. I won't fight you on that, but the former is more consistent. > Also, the second paragraph of the second commit message now belongs in > the first commit (without the word "Also"). Yep, will fix. I usually rewrite commit messages before merging them. -- Michael
signature.asc
Description: PGP signature
