On Tue, Jun 14, 2022 3:36 PM Peter Smith <smithpb2...@gmail.com> wrote:
>
> PSA v2 of the patch, based on all feedback received.
>
> ~~~
>
> Main differences from v1:
>
> * Rewording and more explanatory text.
>
> * The examples were moved to the "Subscription" [1] page and also
> extended to show some normal replication and row filter examples, from
> [Amit].
>
> * Added some text to CREATE PUBLICATION 'publish' param [2], from
> [Euler][Amit].
>
> * Added some text to CREATE SUBSCRIPTION Notes [3], from [Shi-san].
>
> * Added some text to the "Publication page" [4] to say the 'publish'
> is only for DML operations.
>
> * I changed the note in "Row Filter - Initial Data Synchronization"
> [5] to be a warning because I felt users could be surprised to see
> data exposed by the initial copy, which a DML operation would not
> expose.
>
Thanks for updating the patch. Two comments:
1.
+ it means the copied table <literal>t3</literal> contains all rows even
when
+ they do not patch the row filter of publication <literal>pub3b</literal>.
Typo. I think "they do not patch the row filter" should be "they do not match
the row filter", right?
2.
@@ -500,7 +704,6 @@
</para>
</listitem>
</itemizedlist></para>
-
</sect2>
<sect2 id="logical-replication-row-filter-examples">
It seems we should remove this change.
Regards,
Shi yu
