On Tue, Jun 14, 2022 8:57 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > v4-0002 looks good btw, except the bitpick about test comment similar > > to my earlier comment regarding v5-0001: > > > > +# Change the column order of table on publisher > > > > I think it might be better to say something specific to describe the > > test intent, like: > > > > Test that replication into partitioned target table continues to works > > correctly when the published table is altered > > > > Okay changed this and slightly modify the comments and commit message. > I am just attaching the HEAD patches for the first two issues. >
Thanks for updating the patch. Attached the new patch set which ran pgindent, and the patches for pg14 and pg13. (Only the first two patches of the patch set.) Regards, Shi yu
v8-pg14-0002-Fix-data-inconsistency-between-publisher-and-su_patch
Description: v8-pg14-0002-Fix-data-inconsistency-between-publisher-and-su_patch
v8-pg14-0001-Fix-cache-look-up-failures-while-applying-chang_patch
Description: v8-pg14-0001-Fix-cache-look-up-failures-while-applying-chang_patch
v8-pg13-0002-Fix-data-inconsistency-between-publisher-and-su_patch
Description: v8-pg13-0002-Fix-data-inconsistency-between-publisher-and-su_patch
v8-pg13-0001-Fix-cache-look-up-failures-while-applying-chang_patch
Description: v8-pg13-0001-Fix-cache-look-up-failures-while-applying-chang_patch
v8-0002-Fix-data-inconsistency-between-publisher-and-subs.patch
Description: v8-0002-Fix-data-inconsistency-between-publisher-and-subs.patch
v8-0001-Fix-cache-look-up-failures-while-applying-changes.patch
Description: v8-0001-Fix-cache-look-up-failures-while-applying-changes.patch