On Thu, June 9, 2022 7:02 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > I think one approach to fix it is to check the target partition in this > > case, > > instead of the partitioned table. > > > > This approach sounds reasonable to me. One minor point: > +/* > + * Check that replica identity matches. > + * > + * We allow for stricter replica identity (fewer columns) on subscriber as > + * that will not stop us from finding unique tuple. IE, if publisher has > + * identity (id,timestamp) and subscriber just (id) this will not be a > + * problem, but in the opposite scenario it will. > + * > + * Don't throw any error here just mark the relation entry as not updatable, > + * as replica identity is only for updates and deletes but inserts can be > + * replicated even without it. > + */ > +static void > +logicalrep_check_updatable(LogicalRepRelMapEntry *entry) > > Can we name this function as logicalrep_rel_mark_updatable as we are > doing that? If so, change the comments as well. >
OK. Modified. > > When trying to fix it, I saw some other problems about updating partition > map > > cache. > > > > a) In logicalrep_partmap_invalidate_cb(), the type of the entry in > > LogicalRepPartMap should be LogicalRepPartMapEntry, instead of > > LogicalRepRelMapEntry. > > > > b) In logicalrep_partition_open(), it didn't check if the entry is valid. > > > > c) When the publisher send new relation mapping, only relation map cache > will be > > updated, and partition map cache wouldn't. I think it also should be updated > > because it has remote relation information, too. > > > > Is there any test case that can show the problem due to your above > observations? > Please see the following case. -- publisher create table tbl (a int primary key, b int); create publication pub for table tbl; -- subscriber create table tbl (a int primary key, b int, c int) partition by range (a); create table child partition of tbl default; -- publisher, make cache insert into tbl values (1,1); update tbl set a=a+1; alter table tbl add column c int; update tbl set c=1 where a=2; -- subscriber postgres=# select * from tbl; a | b | c ---+---+--- 2 | 1 | (1 row) The value of column c updated failed on subscriber. And after applying the first patch, it would work fine. I have added this case to the first patch. Also add a test case for the second patch. Attach the new patches. Regards, Shi yu
v2-0001-Fix-partition-map-cache-issues.patch
Description: v2-0001-Fix-partition-map-cache-issues.patch
v2-0002-Check-partition-table-replica-identity-on-subscri.patch
Description: v2-0002-Check-partition-table-replica-identity-on-subscri.patch
