On 11 April 2018 at 21:22, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: >> Also just wondering if it's worth adding some verification that we've >> actually eliminated the correct partitions by backing the tests up >> with a call to satisfies_hash_partition. >> >> I've attached a delta patch that applies to your v2 which does this. >> Do you think it's worth doing? > > We can see check by inspection that individual values are in appropriate > partitions, which is the point of having the inserts and the select just > above the actual pruning related tests. So, I'm not sure if adding the > satisfies_hash_partition against each pruning tests adds much.
Right, that's true. > Attached revised patch. Thanks. It looks fine to me, with or without the satisfies_hash_partition tests. I agree that they're probably overkill, but I see you've added them now. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
