Hello hackers, While exploring some code in logical replication worker implementation, I noticed that we're accessing an invalid memory while traversing LogicalRepCtx->workers[i]. For the above structure, we're allocating max_logical_replication_workers times LogicalRepWorker amount of memory in ApplyLauncherShmemSize. But, in the for loop, we're accessing the max_logical_replication_workers + 1 location which is resulting in random crashes.
Please find the patch that fixes the issue. I'm not sure whether we should add a regression test for the same. -- Thanks & Regards, Kuntal Ghosh
0001-Fix-terminating-condition-while-fetching-the-replica.patch
Description: Binary data
