Hi all, I am catching up with new features so I have begun going through Covering indexes. While reading the code, I have noticed a couple of things: 1) Some typos. 2) An inconsistent variable name in pg_dump.
The thing and structure of the code is pretty interesting by the way. That's nice work. I am still trying to break the DDL data like NULL-ness of columns for some weird combinations of columns without being able to. Thanks, -- Michael
diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c index 3ef861494b..10509cfe8a 100644 --- a/src/backend/access/nbtree/nbtinsert.c +++ b/src/backend/access/nbtree/nbtinsert.c @@ -1733,8 +1733,8 @@ _bt_checksplitloc(FindSplitData *state, /* * The first item on the right page becomes the high key of the left page; * therefore it counts against left space as well as right space. When - * index has included attribues, then those attributes of left page high - * key will be truncate leaving that page with slightly more free space. + * index has included attributes, then those attributes of left page high + * key will be truncated leaving that page with slightly more free space. * However, that shouldn't affect our ability to find valid split * location, because anyway split location should exists even without high * key truncation. diff --git a/src/backend/access/nbtree/nbtutils.c b/src/backend/access/nbtree/nbtutils.c index 12b636253e..eedb7a91e9 100644 --- a/src/backend/access/nbtree/nbtutils.c +++ b/src/backend/access/nbtree/nbtutils.c @@ -2087,7 +2087,8 @@ btproperty(Oid index_oid, int attno, * * Transforms an ordinal B-tree leaf index tuple into pivot tuple to be used * as hikey or non-leaf page tuple with downlink. Note that t_tid offset - * will be overritten in order to represent number of present tuple attributes. + * will be overwritten in order to represent number of present tuple + * attributes. */ IndexTuple _bt_truncate_tuple(Relation idxrel, IndexTuple olditup) diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index 93c869fd68..b11fe94212 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -6726,7 +6726,7 @@ getIndexes(Archive *fout, TableInfo tblinfo[], int numTables) i_indexname, i_parentidx, i_indexdef, - i_indnnkeyatts, + i_indnkeyatts, i_indnatts, i_indkey, i_indisclustered, @@ -6952,7 +6952,7 @@ getIndexes(Archive *fout, TableInfo tblinfo[], int numTables) i_indexname = PQfnumber(res, "indexname"); i_parentidx = PQfnumber(res, "parentidx"); i_indexdef = PQfnumber(res, "indexdef"); - i_indnnkeyatts = PQfnumber(res, "indnkeyatts"); + i_indnkeyatts = PQfnumber(res, "indnkeyatts"); i_indnatts = PQfnumber(res, "indnatts"); i_indkey = PQfnumber(res, "indkey"); i_indisclustered = PQfnumber(res, "indisclustered"); @@ -6986,7 +6986,7 @@ getIndexes(Archive *fout, TableInfo tblinfo[], int numTables) indxinfo[j].dobj.namespace = tbinfo->dobj.namespace; indxinfo[j].indextable = tbinfo; indxinfo[j].indexdef = pg_strdup(PQgetvalue(res, j, i_indexdef)); - indxinfo[j].indnkeyattrs = atoi(PQgetvalue(res, j, i_indnnkeyatts)); + indxinfo[j].indnkeyattrs = atoi(PQgetvalue(res, j, i_indnkeyatts)); indxinfo[j].indnattrs = atoi(PQgetvalue(res, j, i_indnatts)); indxinfo[j].tablespace = pg_strdup(PQgetvalue(res, j, i_tablespace)); indxinfo[j].indreloptions = pg_strdup(PQgetvalue(res, j, i_indreloptions));
signature.asc
Description: PGP signature
