On Tue, Apr 10, 2018 at 6:58 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Well, the question that's bothering me is how come "make check" in > an external build doesn't try to execute the temp-install rule before > printing that error message. Experimentation shows that it doesn't, > but it sure looks to me like it should: there's nothing conditional > about the "check: temp-install" dependency in Makefile.global. And > none of the three if-guards in the temp-install rule itself should > prevent this, so what is preventing it? I don't see it.
I just checked, and for the record the second rule (ifneq ($(abs_top_builddir),) is actually preventing it. On top of Makefile.global: # Set top_srcdir, srcdir, and VPATH. ifdef PGXS top_srcdir = $(top_builddir) [...] else # not PGXS [...] abs_top_builddir = @abs_top_builddir@ [...] endif # not PGXS > > For this reason, I thought that adding NO_TEMP_INSTALL would be a good > safety factor in case somebody changes/breaks whatever unobvious > thing is keeping this from failing, and so I went ahead and did it. It makes sense. Thanks for correcting and pushing!
