On Mon, Feb 28, 2022 at 7:31 PM Sergei Kornilov <s...@zsrv.org> wrote:
>
> Hello
> I just spotted in src/include/access/xlog.h:
> extern XLogRecPtr CalculateMaxmumSafeLSN(void);
>
> This function doesn't seem to be used anywhere or even defined? "git grep 
> CalculateMaxmumSafeLSN" shows only this line.
> Was added in c6550776394e25c1620bc8258427c8f1d448080d "Allow users to limit 
> storage reserved by replication slots"

+1 to remove. Although the change is straightforward, I attached the
patch just for the sake of convention. I've marked it as RfC
https://commitfest.postgresql.org/38/3616/.

Just for the record - there's another thread
https://www.postgresql.org/message-id/CALj2ACVoQ7NEf43Xz0rfxsGOKYTN5r4VZp2DO2_5p%2BCMzsRPFw%40mail.gmail.com

Regards,
Bharath Rupireddy.

Attachment: v1-0001-Remove-an-undefined-function-CalculateMaxmumSafeL.patch
Description: Binary data

Reply via email to