On Tue, May 10, 2022 at 09:12:49AM -0700, Nathan Bossart wrote: > AFAICT you need to set log_min_messages to at least DEBUG3 to see extra > output for the non-runtime-computed GUCs, so it might not be worth the > added complexity.
This set of messages is showing up for ages with zero complaints from the field AFAIK, and nobody would use this level of logging except developers. One thing that overriding log_min_messages to FATAL does, however, is to not show anymore those debug3 messages when querying a runtime-computed GUC, but that's the kind of things we'd hide. Your patch would hide those entries in both cases. Perhaps we could do that, but at the end, I don't really see any need to complicate this code path more than necessary, and this is enough to silence the logs in the cases we care about basically all the time, even if the log levels are reduced a bit on a given cluster. Hence, I have applied the simplest solution to just enforce a log_min_messages=FATAL when requesting a runtime GUC. -- Michael
signature.asc
Description: PGP signature
