On 20.04.22 22:45, Tom Lane wrote:
I think the right way to fix #2 is to put the responsibility for
generating the #define's into genbki.pl, instead of this mistake-prone
approach of duplicating the OID constants in the source code.
The attached proposed patch invents a variant macro
DECLARE_TOAST_WITH_MACRO for the relatively small number of cases
where we need such OID macros.
This makes sense.
A more elaborate (future) project would be to have genbki.pl generate
all of IsSharedRelation(), which is the only place these toast-table-OID
macros are used, AFAICT.
