On Thu, Apr 21, 2022 at 8:38 AM Thomas Munro <thomas.mu...@gmail.com> wrote: > On Thu, Apr 21, 2022 at 7:35 AM Robert Haas <robertmh...@gmail.com> wrote: > > On Wed, Apr 20, 2022 at 3:08 PM Thomas Munro <thomas.mu...@gmail.com> wrote: > > > Looks like this somehow broke on a Windows box: > > > > > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2022-04-20%2016%3A34%3A19 > > > > So the issue here is that we are running this command: > > > > pg_dumpall --exclude-database .* > > > > And on that Windows machine, .* is being expanded to .gitignore, so > > pg_dumpall prints: > > > > pg_dumpall: error: improper qualified name (too many dotted names): > > .gitignore > > > > Instead of: > > > > pg_dumpall: error: improper qualified name (too many dotted names): .* > > > > I don't know why that glob-expansion only happens on jacana, and I > > don't know how to fix it, either. > > Perhaps bowerbird and jacana have different versions of IPC::Run? I > see some recent-ish changes to escaping logic in here from Noah: > > https://github.com/toddr/IPC-Run/commits/master/lib/IPC/Run/Win32Helper.pm > > Looks like the older version looks for meta characters not including > '*', and the later one uses Win32::ShellQuote::quote_native.
This time with Andrew in CC.
