On Wed, Apr 20, 2022 at 2:38 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Apr 20, 2022 at 12:51 PM Masahiko Sawada <sawada.m...@gmail.com> > wrote: > > > > On Wed, Apr 20, 2022 at 11:46 AM wangw.f...@fujitsu.com > > <wangw.f...@fujitsu.com> wrote: > > > ``` > > > > I'm concerned that this 4-byte padding at the end of the struct could > > depend on platforms (there might be no padding in 32-bit platforms?). > > > > Good point, but ... > > > It seems to me that it's better to put it after fast_forward where the > > new field should fall within the padding space. > > > > Can we add the variable in between the existing variables in the > structure in the back branches? >
I think it should be fine if it falls in the padding space. We have done similar changes recently in back-branches [1]. I think it would be then better to have it in the same place in HEAD as well? [1] - https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=10520f4346876aad4941797c2255a21bdac74739 -- With Regards, Amit Kapila.
