Japin Li <japi...@hotmail.com> writes:
> On Mon, 18 Apr 2022 at 22:41, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> A lot of these changes look wrong to me: they are substituting "rb" for
>> "r", etc, in places that mean to read text files. You have to think
>> about the Windows semantics.
> I do this substituting, since the comment says it can be used for opening
> text files. Maybe I misunderstand the comment.
I think the comment's at best misleading. See e.g. 66f8687a8.
It might be okay to use "rb" to read a text file when there
is actually \r-stripping logic present, but you need to check
that. Using "wb" to write a text file is flat wrong.
regards, tom lane
