On Sun, Apr 8, 2018 at 5:36 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > Won't in the success case, you need to delete each member (by > something like bms_del_member) rather than just using bms_free?
Thanks for looking at this. Yeah, if requests for segment numbers 0 and 1 were in "requests", and 0 succeeded but then 1 fails, my previous patch would leave both in there to be retried next time around. I thought that was pretty harmless so I didn't worry about it before, but of course you're right that it's not necessary to retry the ones that succeeded, so we could remove them as we go. New patch attached. -- Thomas Munro http://www.enterprisedb.com
0001-Make-sure-we-don-t-forget-about-fsync-requests-af-v3.patch
Description: Binary data