Hi, On 2018-04-07 13:45:21 -0400, Tom Lane wrote: > Simon Riggs <si...@2ndquadrant.com> writes: > > On 6 April 2018 at 17:22, Bruce Momjian <br...@momjian.us> wrote: > >> My point was that people didn't ask you to work harder on fixing the > >> patch, but in reverting it. You can work harder on fixing things in the > >> hope they change their minds, but again, that isn't addressing their > >> request. > > > If Tom or Andres still feel that their concerns have not been > > addressed over the last few days, I am happy to revert the patch with > > no further discussion from me in this cycle. > > FWIW, I still vote to revert. Even if the patch were now perfect, > there is not time for people to satisfy themselves of that, and > we've got lots of other things on our plates.
Precisely. And no, I don't think the concerns have been addressed fully. > I'd be glad to participate in a proper review of this when v12 > opens. But right now it just seems too rushed, and I have little > confidence in it being right. Yea, I'd really hope this gets submitted *early* in the v12 cycle rather than leaving it to the end. I'd even be willing to produce a prototype of what I think should be changed in the parse-analysis & executor stages, if necessary. Greetings, Andres Freund
