On 2022-Mar-24, Japin Li wrote: > Thanks for your detail explaination. I find bottomup_sort_and_shrink_cmp() > has smilar code
... except that bottomup_sort_and_shrink_cmp never handles the case of the two structs being exactly identical, so I don't think this is a great counter-example. > IIUC, the last statement is used to keep the compiler quiet. However, > it doesn't exist in LWLockAttemptLock(). Why? What I do care about is the fact that LWLockAttemptLock does compile silently everywhere without a final "return dummy_value" statement. I don't have to build a theory for why the other function has a statement that may or may not be actually doing anything. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Los dioses no protegen a los insensatos. Éstos reciben protección de otros insensatos mejor dotados" (Luis Wu, Mundo Anillo)
