Robert Haas <robertmh...@gmail.com> writes: > I think that the code is perfectly readable as it is and that this > change makes it less so.
Yeah, after a quick look through this patch I'm unimpressed too. The new code is strictly longer, and it requires the introduction of distracting "!" and "&" operators in many places. regards, tom lane