On Mon, Mar 21, 2022, at 12:25 AM, Amit Kapila wrote: > I have fixed all the above comments as per your suggestion in the > attached. Do let me know if something is missed? Looks good to me.
> > src/test/subscription/t/029_disable_on_error.pl | 94 ---------- > > src/test/subscription/t/029_on_error.pl | 183 +++++++++++++++++++ > > > > It seems you are removing a test for > > 705e20f8550c0e8e47c0b6b20b5f5ffd6ffd9e33. > > I should also name 029_on_error.pl to something else such as > > 030_skip_lsn.pl or > > a generic name 030_skip_option.pl. > > > > As explained in my previous email, I don't think any change is > required for this comment but do let me know if you still think so? Oh, sorry about the noise. I saw mixed tests between the 2 new features and I was confused if it was intentional or not. -- Euler Taveira EDB https://www.enterprisedb.com/
