Hi, On 2022-03-18 20:28:58 +0100, Peter Eisentraut wrote: > Why does your patch introduce a function check_icu_locale() that is only > called once? Did you have further plans for that?
I like that it moves ICU code out of dbcommands.c - imo there should be few calls to ICU functions outside of pg_locale.c. There might be an argument for moving *more* into such a function though. Greetings, Andres Freund