"Euler Taveira" <eu...@eulerto.com> writes: > On Fri, Feb 18, 2022, at 2:47 PM, Renan Soares Lopes wrote: >> I added a patch to fix table_to_xmlschema, could you point me how to add a >> unit test to that?
> You should edit src/test/regress/expected/xmlmap.out. In this case, you should > also modify src/test/regress/expected/xmlmap_1.out that the output from this > test when you build without libxml support. Run 'make check' to test your fix > after building with/without libxml support. > Regarding this fix, it looks good to me. FWIW, character class escape is > defined here [1]. LGTM too. Pushed after rethinking the test case a bit. regards, tom lane