On Wed, Feb 2, 2022 at 3:08 AM Amit Langote <amitlangot...@gmail.com> wrote: > I noticed $subject while looking at something involving SubLinks and > SubPlans. It seems eab6b8b27eb removed the "plan" field from the > SubPlan node struct definition, but the following line from > expression_tree_mutator(): > > /* but not the sub-Plan itself, which is referenced as-is */ > > and the following from expression_tree_walker(): > > /* recurse into the testexpr, but not into the Plan */ > > both of which I think refer to that no-longer-existent field, appear > to have survived multiple commits that moved the SubPlan expression > processing code around. > > Attached patch removes those.
Looks right to me. Tom, any comments? -- Robert Haas EDB: http://www.enterprisedb.com
