On Mon, Mar 7, 2022 at 3:56 PM Peter Smith <smithpb2...@gmail.com> wrote:
>
> Hi Vignesh, I also have not looked at the patch yet, but I have what
> seems like a very fundamental (and possibly dumb) question...
>
> Basically, I do not understand the choice of syntax for setting things up.
>
> IMO that "only-local" option sounds very similar to the other
> PUBLICATION ("publish") options which decide the kinds of things that
> will be published. So it feels more natural for me to think of the
> publisher as being the one to decide what will be published.
>
> e.g.
>
> option 1:
> CREATE PUBLICATION p1 FOR TABLE t1;
> CREATE SUBSCRITION s1 ... FOR PUBLICATION p1 WITH (only_local = true);
>
> option 2:
> CREATE PUBLICATION p1 FOR TABLE t1 WEHRE (publish = 'only_local');
> CREATE SUBSCRITION s1 ... FOR PUBLICATION p1;
>Sorry, I mean to write WITH. option 2: CREATE PUBLICATION p1 FOR TABLE t1 WITH (publish = 'only_local'); CREATE SUBSCRITION s1 ... FOR PUBLICATION p1; > ~~ > > IIUC the patch is using option 1. My first impression was it feels > back-to-front for the SUBSCRIPTION telling the PUBLICATION what to > publish. > > So, why does the patch use syntax option 1? > > ------ > Kind Regards, > Peter Smith > Fujitsu Australia
