Hi Yugo and Fabien, It seems the patch is ready for committer except below. Do you guys want to do more on below?
>> # TESTS >> >> I suggested to simplify the tests by using conditionals & sequences. You >> reported that you got stuck. Hmmm. >> >> I tried again my tests which worked fine when started with 2 clients, >> otherwise they get stuck because the first client waits for the other one >> which does not exists (the point is to generate deadlocks and other >> errors). Maybe this is your issue? > > That seems to be right. It got stuck when I used -T option rather than -t, > it was because, I guess, the number of transactions on each thread was > different. > >> Could you try with: >> >> psql < deadlock_prep.sql >> pgbench -t 4 -c 2 -f deadlock.sql >> # note: each deadlock detection takes 1 second >> >> psql < deadlock_prep.sql >> pgbench -t 10 -c 2 -f serializable.sql >> # very quick 50% serialization errors > > That works. However, it still gets hang when --max-tries = 2, > so maybe I would not think we can use it for testing the retry > feature.... Best reagards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
