On Wed, Mar 2, 2022 at 10:39 AM Andres Freund <and...@anarazel.de> wrote: > > Working on rebasing shared memory stats over this. Feels *much* better so far. >
Good to hear that it helps. BTW, there is another patch [1] that extends this view. I think that patch is still not ready but once it is ready (which I expect to happen sometime in this CF), it might be good if you would be able to check whether it has any major problem with your integration. > While rebasing, I was wondering why pgstat_reset_subscription_counter() has > "all subscription counters" support. We don't have a function to reset all > function stats or such either. > We have similar thing for srlu (pg_stat_reset_slru) and slots (pg_stat_reset_replication_slot). For functions and tables, one can use pg_stat_reset. Similarly, we have pg_stat_reset_shared() which reset stats like WAL. This matches more with slru/slots, so we providied it via pg_stat_reset_subscription_stats. [1] - https://www.postgresql.org/message-id/TYWPR01MB8362B30A904274A911C0B1CCED039%40TYWPR01MB8362.jpnprd01.prod.outlook.com -- With Regards, Amit Kapila.
