Hi, On Mon, Feb 28, 2022 at 10:21:23AM +0530, Bharath Rupireddy wrote: > > Another thought for my review comment: > > 1) Can't we use pg_is_in_recovery to determine if it's a restartpoint > > or checkpoint instead of having a new function > > pg_stat_get_progress_checkpoint_type? > > I don't think using pg_is_in_recovery work here as it is taken after > the checkpoint has started. So, I think the right way here is to send > 1 in CreateCheckPoint and 2 in CreateRestartPoint and use > CASE-WHEN-ELSE-END to show "1": "checkpoint" "2":"restartpoint".
I suggested upthread to store the starting timeline instead. This way you can deduce whether it's a restartpoint or a checkpoint, but you can also deduce other information, like what was the starting WAL. > 11) I think it's discussed, are we going to add the pid of the > checkpoint requestor? As mentioned upthread, there can be multiple backends that request a checkpoint, so unless we want to store an array of pid we should store a number of backend that are waiting for a new checkpoint.
