On Thu, Feb 24, 2022 at 9:20 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > > 6. src/backend/postmaster/pgstat.c - function name > > > > +/* ---------- > > + * pgstat_reset_subscription_counter() - > > + * > > + * Tell the statistics collector to reset a single subscription > > + * counter, or all subscription counters (when subid is InvalidOid). > > + * > > + * Permission checking for this function is managed through the normal > > + * GRANT system. > > + * ---------- > > + */ > > +void > > +pgstat_reset_subscription_counter(Oid subid) > > > > SUGGESTION (function name) > > "pgstat_reset_subscription_counter" --> > > "pgstat_reset_subscription_counters" (plural) > > Fixed. >
We don't use the plural form in other similar cases like pgstat_reset_replslot_counter, pgstat_reset_slru_counter, so why do it differently here? -- With Regards, Amit Kapila.
