On 23.02.22 03:14, Andres Freund wrote:
Why are the stats stored in the per-database stats file / as a second level below the database? While they're also associated with a database, it's a global catalog, so it seems to make more sense to have them "live" globally as well?
pg_subscription being a global catalog is a bit of a lie for the benefit of the worker launcher, but it can be treated as a per-database catalog for practical purposes.
Not just from an aesthetical perspective, but there might also be cases where it's useful to send stats from the stats launcher. E.g. the number of times the launcher couldn't start a worker because the max numbers of workers was already active or such.
That's a reasonable point, however.
