somehow you missed some parts in 0001 patch, at least regression tests fail:
CREATE EXTENSION btree_gin;
+ ERROR: could not find function "gin_extract_value_uuid" in file
"/usr/local/pgsql/lib/btree_gin.so"
Matheus de Oliveira wrote:
Hi all.
On Wed, Mar 21, 2018 at 1:47 PM, Tomas Vondra <tomas.von...@2ndquadrant.com
<mailto:tomas.von...@2ndquadrant.com>> wrote:
Do you plan to post an updated version of the patch, of what is your
response to the points raised last week?
Very sorry about the long delay. I've been in a long trip, no time to look that
carefully.
I still haven't made my mind regarding usefulness of range opclasses, so
I suggest to split the patch into two parts - 0001 for the opclasses
we're confident are useful, and 0002 for those extras. The committer
then may apply either 0001 or 0001+0002, depending on his judgment.
I liked the idea. So, follows the patches:
- 0001-btree_gin-uuid--base.v2.patch - all types but anyrange, and with the
adjustments on comments you proposed
- 0002-btree_gin-uuid--anyrange.v2.patch - adding the anyrange type (must be
applied after 0001)
Anything else missing?
Best regards,
--
Matheus de Oliveira
--
Teodor Sigaev E-mail: teo...@sigaev.ru
WWW: http://www.sigaev.ru/
