On Tue, Feb 15, 2022 at 03:23:30PM -0500, Robert Haas wrote: > On Tue, Feb 15, 2022 at 1:55 PM Justin Pryzby <pry...@telsasoft.com> wrote: > > Regarding the patch: > > > > I suppose it should support windows, and whatever patches use zstd should > > update the install instructions. See 9ca40dcd4, 02a93e7ef, 4035cd5d4. > > Thanks, this is helpful. To me, it looks like we need something > similar to 9ca40dcd4, plus something like the last hunk of 02a93e7ef.
If you mean a patch which only adds the configure options, I don't think 02a9 is applicable at all. What I mean is that any patches which *use* the zstd support should update those for completeness. doc/src/sgml/config.sgml | 14 +++++++++----- doc/src/sgml/install-windows.sgml | 2 +- doc/src/sgml/installation.sgml | 5 +++-- > The rest of 02a93e7ef and all of 4035cd5d4 seem like they address the > application of lz4 rather than just adding support for it, so I don't > see the need for those elements in this patch. Am I missing something?
