On Mon, Feb 7, 2022 at 4:22 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > Hi, > > While working on pg_replslotdata tool [1], it was observed that some > of the replication slot structures/enums/macros such as > ReplicationSlotPersistentData, ReplicationSlotPersistency, > ReplicationSlotOnDisk, ReplicationSlotOnDiskXXXX etc. are currently in > replication/slot.h and replication/slot.c. This makes the replication > slot on disk data structures unusable by the external tools/modules. > How about moving these structures to a new header file called > slot_common.h as attached in the patch here? > > Thoughts? > > PS: I'm planning to have the tool separately, as it was rejected to be in > core. > > [1] > https://www.postgresql.org/message-id/CALj2ACW0rV5gWK8A3m6_X62qH%2BVfaq5hznC%3Di0R5Wojt5%2Byhyw%40mail.gmail.com > > Regards, > Bharath Rupireddy.
Recently I was also looking to add some new enums but I found it was difficult to find any good place to put them where they could be shared by the replication code and the pg_recvlogical tool. So +1 to your suggestion to have a common header, but I wonder can it have a more generic name (e.g. repl_common.h? ...) since the stuff I wanted to put there was not really "slot" related. ------ Kind Regards, Peter Smith. Fujitsu Australia.
