Hello, Fujii-san, On Fri, 4 Feb 2022 09:08:22 +0900 Fujii Masao <masao.fu...@oss.nttdata.com> wrote:
> > > On 2022/02/04 1:46, Yugo NAGATA wrote: > > Hello, > > > > I found a old parameter name 'heapRelation' in the comment > > of CheckIndexCompatible. This parameter was removed by 5f173040. > > > > Attached is a patch to remove it from the comment. > > Thanks for the report! I agree to remove the mention of parameter already > dropped, from the comment. OTOH, I found CheckIndexCompatible() now has > "oldId" parameter but there is no comment about it though there are comments > about other parameters. Isn't it better to add the comment about "oldId"? Agreed. I updated the patch to add a comment about 'oldId'. Regards, Yugo Nagata -- Yugo NAGATA <nag...@sraoss.co.jp>
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c index 560dcc87a2..408ffc70f6 100644 --- a/src/backend/commands/indexcmds.c +++ b/src/backend/commands/indexcmds.c @@ -129,7 +129,7 @@ typedef struct ReindexErrorInfo * prospective index definition, such that the existing index storage * could become the storage of the new index, avoiding a rebuild. * - * 'heapRelation': the relation the index would apply to. + * 'oldId': the existing index's relation OID * 'accessMethodName': name of the AM to use. * 'attributeList': a list of IndexElem specifying columns and expressions * to index on.
